jmejia8 / Metaheuristics.jl

High-performance metaheuristics for optimization coded purely in Julia.
https://jmejia8.github.io/Metaheuristics.jl/stable/
Other
253 stars 27 forks source link

Is there a reason the samplers generate row instead of column matrices? Julia is column major #104

Open jonathanfischer97 opened 7 months ago

jonathanfischer97 commented 7 months ago

The AbstractSamplers generate matrices where data is organized by row instead of column. So when a user writes a parallelized objective function for example, they must iterate by row:

function f_parallel(X)
     fitness = zeros(size(X,1))
     Threads.@threads for i in 1:size(X,1)
         fitness[i] = f(X[i,:])
     end
     fitness
 end

This is atypical in Julia, as most users and external packages organize data by column. Additionally, iterating by row is discouraged, as Julia is column major and thus the row values will not be stored contiguously, causing cache misses.

Was just wondering if this was by design or if their was a good reason for this? I'm adding the option in my fork for users to initialize methods with a pre-generated population, so I need to exchange a lot of the length calls for size in _complete_population!, and would like to abide by your original design in case of eventual PR/merge.

If not, I'll move my fork to completely column major and make my changes based on that.

jmejia8 commented 7 months ago

Hi @jonathanfischer97

The row major implementation in the whole package comes from its genesis without any specific reason (my fault since that), and we need to move to the typical way in Julia (column major).

Thanks!