C Codec: Memory Leaks -- Who deletes and who copies

jmenashe / rl-glue-ext

Automatically exported from code.google.com/p/rl-glue-ext

0 stars 0 forks source link

C Codec: Memory Leaks -- Who deletes and who copies #12

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

The C codec pulls things off the network and then passes them back to the
ae^2.  (Agent, Environment, Experiment).

I think it's using some static global variables for things like the message
strings, observations, etc.  We should nail down and LOUDLY document
whether you have to make a copy of these things if you want to store them,
how to make a copy, and how to clean it up.

Original issue reported on code.google.com by brian.ta...@gmail.com on 7 Sep 2008 at 6:21

GoogleCodeExporter commented 8 years ago

Original comment by brian.ta...@gmail.com on 13 Sep 2008 at 5:25

Added labels: Codec-Java

GoogleCodeExporter commented 8 years ago

Should run this all through valgrind.

Original comment by brian.ta...@gmail.com on 16 Sep 2008 at 10:44

Changed state: Started

GoogleCodeExporter commented 8 years ago

We ran the basic stuff through valgrind, and fixed a few problems.

At some later date when we have time we should do a solid optimization pass and 
make
sure there are no minor memory leaks.

Original comment by brian.ta...@gmail.com on 1 Oct 2008 at 6:44

Added labels: Milestone-Future, Priority-Low
Removed labels: Codec-Java, Milestone-Journal, Priority-Critical

GoogleCodeExporter commented 8 years ago

Everything had been through valgrind, and all of the stuff that is getting 
passed
around is const pointers now.

So, this should be considered done.

Original comment by brian.ta...@gmail.com on 15 Oct 2008 at 1:55

Changed state: Fixed