jmenashe / rl-glue-ext

Automatically exported from code.google.com/p/rl-glue-ext
0 stars 0 forks source link

Codecs RC-Final-1 Code review #53

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
When reviewing my code changes, please focus on:
Installation

    * Is the install process obvious/natural for a user of this language
    * Is there a more automated or transparent process for installation
that you have seen elsewhere?
    * Are there any dependencies (root access, software dependencies) that
any user (including an undergraduate student working on dept machines) may
not have?
    * Are there any steps that are implicitly expected and not explained in
the instructions
    * Any superfluous steps that are obviously not required?

Usage

    * Are there any steps that would be a hassle if done on a regular
basis?  Like adding paths to the Matlab code or setting LD_LIBRARY_PATH in
C/C++ if not installing as root?
          o Can you think of how to resolve these hassles?  Perhaps an
explanation of how to update .bashrc or something of that nature?

Conventions

    * Are file names and/or function/method names usually specified
differently than we have for this particular language?  For example, in
Java we have tried to use camelCase, and in C we have used under_scores.

    *  Are comments written in the appropriate format?  For example, in
Java we use JavaDoc. 

Documentation

    * Anything that is explained poorly in the documentation
          o Perhaps re-ordering would make the information more clear
          o Perhaps a few more little snippets of information are required
          o Different wording?
          o Shorter examples?

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by brian.ta...@gmail.com on 4 Feb 2009 at 2:45

GoogleCodeExporter commented 8 years ago

Original comment by brian.ta...@gmail.com on 7 Feb 2009 at 11:45

GoogleCodeExporter commented 8 years ago
Thanks to everyone for the great feedback, I think we addressed almost all of 
it!

Original comment by brian.ta...@gmail.com on 13 Feb 2009 at 12:49