search

jmert / AssociatedLegendrePolynomials.jl

A library for calculating the Associated Legendre polynomials
https://jmert.github.io/AssociatedLegendrePolynomials.jl/
MIT License
20 stars 2 forks source link

Eliminate uses of `@fastmath(sqrt)` #29

Closed jmert closed 2 years ago

jmert commented 2 years ago

For machine integer and floating point types, uses the LLVM sqrt intrinsic instead, while falling back to Base.sqrt for all other types so that generic type handling still works.

Fixes #22

codecov[bot] commented 2 years ago

Codecov Report

Merging #29 (ce4baf9) into master (4292efd) will decrease coverage by 1.87%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   98.41%   96.54%   -1.88%     
==========================================
  Files           9        9              
  Lines         316      347      +31     
==========================================
+ Hits          311      335      +24     
- Misses          5       12       +7
Impacted Files Coverage Δ
src/norm_sphere.jl 97.14% <85.71%> (-2.86%) :arrow_down:
src/calculation.jl 94.40% <0.00%> (-3.61%) :arrow_down:
src/norm_unit.jl 100.00% <0.00%> (ø)
src/norm_table.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a39ab8...ce4baf9. Read the comment docs.