Closed jmert closed 1 year ago
Merging #33 (5603444) into master (b0df887) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 9 9
Lines 350 350
=======================================
Hits 338 338
Misses 12 12
Impacted Files | Coverage Δ | |
---|---|---|
src/calculation.jl | 94.40% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The other recursion coefficients were already all using only real number types, but the initial condition was forgotten. This has worked thus far, but a change in the upcoming Julia v1.9 (presumably JuliaLang/julia#47255) broke the exact correspondance between real inputs and real-axis complex inputs for the spherical normalization.
Specifically, on Julia 1.8:
while with Julia 1.9:
The simple change that allows the tests to pass again is to just ask for the initial condition to be calculated in the appropriate real number type.