search

jmesnil / stomp-websocket

Stomp client for Web browsers and node.js apps
http://jmesnil.net/stomp-websocket/doc/
Apache License 2.0
1.43k stars 587 forks source link

Missing bower.json in repo #47

Closed techniq closed 10 years ago

techniq commented 10 years ago

When using the grunt-bower-install task to automatically inject Bower components into our app, we're receiving the following error:

Running "bower-install:app" (bower-install) task

stomp-websocket was not injected in your file.
Please go take a look in "public/bower_components/stomp-websocket" for the file you need, then manually include it in your file.

I believe the is due the stomp-websocket repo does not including a bower.json file with a main attribute. Here's an example - https://github.com/angular/bower-angular/blob/master/bower.json

jmesnil commented 10 years ago

would you like to contribute a bower-stompjs project?

techniq commented 10 years ago

I've not made a bower package before but could look into it. How would this work since ithe project has already been registered in the bower repository:

http://bower.io/search/#!/search/stomp http://bower.io/#registering-packages

paulvitic commented 10 years ago

Any progress on this issue? Should I try to have a go at this?

jmesnil commented 10 years ago

Do you have still use to install it.

I just tried and it seems working fine:

$ bower install stomp-websocket
bower stomp-websocket#*     not-cached git://github.com/jmesnil/stomp-websocket.git#*
bower stomp-websocket#*        resolve git://github.com/jmesnil/stomp-websocket.git#*
bower stomp-websocket#*       download https://github.com/jmesnil/stomp-websocket/archive/2.3.1.tar.gz
bower stomp-websocket#*        extract archive.tar.gz
bower stomp-websocket#*       resolved git://github.com/jmesnil/stomp-websocket.git#2.3.1
bower stomp-websocket#~2.3.1   install stomp-websocket#2.3.1
paulvitic commented 10 years ago

I installed version 2.3.0. I will try 2.3.1 and report back...

techniq commented 10 years ago

I worked around the grunt-bower-install issue myself by adding an override to my project's bower.json:

{
  ...
  "overrides": {
    "stomp-websocket": {
      "main": "lib/stomp.js"
    }
}
paulvitic commented 10 years ago

bower install stomp-websocket#2.3.1 --save

still doesn't generate bower.js in stomp-websocket directory under bower_components. Running "grunt serve" still produces

stomp-websocket was not injected in your file.

warning.

I will try Sean's workaround.