search

jmespath / jmespath.py

JMESPath is a query language for JSON.
http://jmespath.org
MIT License
2.19k stars 181 forks source link

None to NoneType #129

Closed ophiry closed 7 years ago

ophiry commented 7 years ago

bugfix: the type of None should be NoneType instead of None

codecov-io commented 7 years ago

Codecov Report

Merging #129 into develop will decrease coverage by 0.59%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #129     +/-   ##
==========================================
- Coverage    97.27%   96.68%   -0.6%     
==========================================
  Files           13       13             
  Lines         1431     1447     +16     
==========================================
+ Hits          1392     1399      +7     
- Misses          39       48      +9
Impacted Files Coverage Δ
jmespath/functions.py 99.49% <ø> (ø) :arrow_up:
jmespath/compat.py 76.78% <0%> (-13.22%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef36ae7...1691d82. Read the comment docs.

jamesls commented 7 years ago

Not sure why codecov is complaining.

Could you add a test for this change that demonstrates the issue? Once we have that I'll go ahead and merge. Thanks.

gmega commented 7 years ago

Hi there @ophiry @jamesls: I've written the test so that we can see this change merged. :-) I don't see an easy way to integrate my changes in this pull request though. Should I open a new one? Thanks.

jamesls commented 7 years ago

@gmega Feel free to open a new one. Thanks!

jamesls commented 7 years ago

Fixed in https://github.com/jmespath/jmespath.py/pull/145