gmega commented 7 years ago

Hi @jamesls, here's the new pull request for #129. I ended up adding an extra file for the test as test_funcions.py seemed to be reserved for built-in functions and I couldn't find a more suitable place where to put it. Lemme know if that's okay as it is, or if you require any changes. Thanks.

codecov-io commented 7 years ago

Codecov Report

Merging #145 into develop will increase coverage by 0.6%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #145     +/-   ##
==========================================
+ Coverage    96.64%   97.25%   +0.6%     
==========================================
  Files           13       14      +1     
  Lines         1461     1455      -6     
==========================================
+ Hits          1412     1415      +3     
+ Misses          49       40      -9

Impacted Files	Coverage Δ
jmespath/functions.py	`99.49% <ø> (ø)`	:arrow_up:
tests/test_custom_functions.py	`100% <100%> (ø)`
jmespath/__init__.py	`44% <0%> (-6%)`	:arrow_down:
jmespath/compat.py	`90% <0%> (+13.21%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5776050...1f5ca78. Read the comment docs.

jamesls commented 7 years ago

Awesome, thanks for doing this. I went ahead and rebased your commits down to a single commit and merged.

anton-ryzhov commented 6 years ago

I'm looking forward this fix will be in release. When this will happen? Long time had passed since last version, maybe it's time to issue minor version with bugfixes?

anton-ryzhov commented 6 years ago

@jamesls , one year since last release. It would be very nice to have a new one with this bugfix.

jmespath / jmespath.py

reverse type of null should be NoneType, not None #145

Codecov Report