search

jmettraux / rufus-decision

CSV based Ruby decision tables (dead, not maintained anymore)
MIT License
48 stars 5 forks source link

Instrumentation of transform, to allow development of decision table runners that give feedback #14

Open lastobelus opened 11 years ago

lastobelus commented 11 years ago

The data of the instrument includes sparse arrays of row matches, cell matches, and details on how apply! changed columns.

If you would prefer me to squash the commits, let me know and I will. I am forcing myself to become pure TDD, which is why the test coverage is a little verbose.

Also I added guard as a development dependency, let me know if you would prefer to take that out.

The first runner I work on is going to be an Excel template with some VBA to call out to run rufus-decision, and color cells according to the matches, because Excel will be the most useful for my end users.

jmettraux commented 11 years ago

Hello,

thanks for the PR.

Why the bangs at the end of the instrumentation method names? Why not change "table_matched!(x)" to "matched(x)" (shorter and no bang)? I feel that the instrumentation stands out and kills the readability of the code.

lastobelus commented 11 years ago

ok sure. Also just noticed I used 1.9.3 hash syntax, I'll fix that too.