search

jmeyers314 / batoid

c++ backed python optical raytracer
BSD 2-Clause "Simplified" License
21 stars 12 forks source link

Address deprecation warnings in python 3.7 #65

Closed dkirkby closed 5 years ago

dkirkby commented 5 years ago

The unit tests reveal two warnings. The first requires replacing yaml.load(...) with yaml.safe_load(...):

YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.

The second is coming from nbformat and past.types.oldstr (?), so might mean I need to update my conda pkgs:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
jmeyers314 commented 5 years ago

I think I've cleaned up the first warning now. Looks like the second warning has been addressed here and here upstream, though maybe not in released versions yet.

jmeyers314 commented 5 years ago

The yaml deprecation has indeed disappeared from the python3.7 travis run, so closing this.