search

jmeyers314 / batoid

c++ backed python optical raytracer
BSD 2-Clause "Simplified" License
22 stars 13 forks source link

added uniformCircularGrid #73

Closed davidthomas5412 closed 5 years ago

davidthomas5412 commented 5 years ago

Added batoid.uniformCircularGrid because the strict ray grid batoid.circularGrid was producing unwanted image sampling artifacts. There is a corresponding new test in tests/test_ray.py. Should be good to go.

jmeyers314 commented 5 years ago

Thanks David,

I restarted the failing travis-ci jobs, which I think were just timeouts. Usually I've found these pass the second time through. (I need to figure out a way to fix this!)

Also, it looks like you updated the version of pybind11. Was this required for this feature?

codecov-io commented 5 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #73      +/-   ##
=========================================
+ Coverage   88.33%   88.5%   +0.17%     
=========================================
  Files          63      63              
  Lines        3369    3376       +7     
=========================================
+ Hits         2976    2988      +12     
+ Misses        393     388       -5
Impacted Files Coverage Δ
pysrc/batoid.cpp 100% <100%> (ø) :arrow_up:
batoid/__init__.py 100% <100%> (ø) :arrow_up:
src/batoid.cpp 100% <100%> (ø) :arrow_up:
batoid/optic.py 74.04% <0%> (+0.36%) :arrow_up:
batoid/psf.py 93.54% <0%> (+0.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b78df33...1659b19. Read the comment docs.

davidthomas5412 commented 5 years ago

Removed pybind11 changes.

jmeyers314 commented 5 years ago

Hey @davidthomas5412 ,

Just curious what your plans are for this issue. I've actually been thinking about refactoring some of the ray generation code, for instance by making some of the current free functions into class methods of RayVector, and maybe not calling everything a grid, which feels like the wrong name for a lot of these. It'd be nice to have this merged though first.

-Josh

davidthomas5412 commented 5 years ago

Made all of the recommended changes above.