jmgilman / vaultrs

An asynchronous Rust client library for the Hashicorp Vault API
https://docs.rs/vaultrs
MIT License
97 stars 60 forks source link

Considering migrating to testcontainers #80

Open stormshield-gt opened 6 months ago

stormshield-gt commented 6 months ago

I have the following problems with the dockertest-server used in the test suite:

I've successfully used testcontainers with Vault at work and it's really easy to setup. I see a lot of advantages

Haennetz commented 6 months ago

If I understand the stack overflow thread correct the VPN issues root cause is that the VPN network segment overlaps with that one docker chooses. The solution for that would be to specify the range for the docker networks outside the range by the VPN see.

If I understand the documentation of testcontainers correct we have to add a vault module for the vault container?

stormshield-gt commented 3 months ago

If I understand the stack overflow thread correct the VPN issues root cause is that the VPN network segment overlaps with that one docker chooses. The solution for that would be to specify the range for the docker networks outside the range by the VPN see.

You are right I could get away with a configuration, but the point is that with testcontainers I don't have to.

If I understand the documentation of testcontainers correct, we have to add a vault module for the vault container?

There is already an existing one

It's also really easy to define one locally, I've been used a one tailored to our production needs for months now.

Haennetz commented 2 months ago

If you want to, you can prepare a pull request to use testcontainers