search

jmgirard / circumplex

R Package for the Analysis and Visualization of Circumplex Data
http://circumplex.jmgirard.com/
Other
11 stars 6 forks source link

define STRICT_R_HEADERS, include float.h, adjust dbl eps constant #13

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Hi Jeffrey, Hi circumplex team,

Your CRAN package circumplex uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here, I prefixed one #include with STRICT_R_HEADERS. One additional change that is needed is the #include (the compiler may suggst the C++ header #include , that is equivalent). We now can use DBL_EPSILON in two places.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

jmgirard commented 3 years ago

Appreciate the pull request and not just an email - made it very easy on me.

eddelbuettel commented 3 years ago

Thanks for the very swift action, and kind note. I tend to agree -- it is also 'more precise' that copying patches from email. It helps to have URL in DESCRIPTION pointing to the a public repo.