search

jmgreg31 / terraform-aws-cloudfront

AWS Cloudfront Distribution Module
MIT License
27 stars 26 forks source link

Staging #26

Closed jmgreg31 closed 4 years ago

jmgreg31 commented 4 years ago

@schammah here is the error output 

on main.tf line 165, in output "active_trusted_signers":
 165:   value       = module.demo_cf.active_trusted_signers
An output value with the name "active_trusted_signers" has not been declared
in module.demo_cf.

Think it just needs to be modified to trusted_signers

In addition, the travis.yml file should be updated to tf version 13 for valid testing. I'm not sure i'll get a chance to modify this today, so if you'd like to submit another PR to staging I'll merge and re-run

jmgreg31 commented 4 years ago

@schammah nvmd, had some extra time this morning - this lgtm. If the additional small changes look good to you as well I can merge this in.

schammah commented 4 years ago

i see now was sure i modified the example but must have missed it, funny thing is this module doesnt even support setting up / configuring trusted_signers but we output it ;) also for testing it wasn't a must to test with 0.13.1 , this upgrade the provider but still works under both 0.12 & 0.13

anyhow this looks great to me, i suggest you go and merge

jmgreg31 commented 4 years ago

haha, a future release for sure re: trusted_signers.