Allow configuring custom headers in S3.

jmgreg31 / terraform-aws-cloudfront

AWS Cloudfront Distribution Module

MIT License

27 stars 25 forks source link

Allow configuring custom headers in S3. #31

Closed eyal-mor closed 3 years ago

eyal-mor commented 3 years ago

Mimicking the functionality and implementation of dynamic_custom_origin_config variable. Currently this is not possible due to variable validations and will result in a validation failure.

IDE auto removed redundant white spaces.

eyal-mor commented 3 years ago

Hi @jmgreg31!

I work with @schammah and we have found a bug in the current implementation of the dynamic_s3_origin_config when setting custom headers.

Can you please review at your convenience 😄

eyal-mor commented 3 years ago

@schammah Looks like the build is failing. Are you familiar with this issue?

eyal-mor commented 3 years ago

Should have opened a PR to staging branch. Apologizing for the noise!!