search

jmgreg31 / terraform-aws-cloudfront

AWS Cloudfront Distribution Module
MIT License
27 stars 25 forks source link

Eyalmor/fix_custom_headers_dynamic_s3 #32

Closed eyal-mor closed 3 years ago

eyal-mor commented 3 years ago

Add the ability to specify custom headers in the dynamic_s3_origin_config variable. The fix mimics the functionality and implementation of dynamic_custom_origin_config variable.

IDE auto removed redundant white spaces.

eyal-mor commented 3 years ago

Hi @jmgreg31!

I work with @schammah and we have found a bug in the current implementation of the dynamic_s3_origin_config when setting custom headers.

Can you please review at your convenience 😄

jmgreg31 commented 3 years ago

@eyalmor94 thanks for the updates. Can you please update the VERSION file to 4.3.2

eyal-mor commented 3 years ago

@jmgreg31 Updated 😄

jmgreg31 commented 3 years ago

lgtm