jmgreg31 / terraform-aws-cloudfront

AWS Cloudfront Distribution Module
MIT License
27 stars 25 forks source link

Origin Path should not be null #36

Closed jmgreg31 closed 3 years ago

jmgreg31 commented 3 years ago

As mentioned here: https://github.com/hashicorp/terraform-provider-aws/issues/12065, there is a bug with setting the origin path to null as opposed to "". TF plan indicates that the origin will be redeployed, which is an undesired effect.

This does however only seem to happen when an origin is added or removed. If no changes have been made to origin, leaving the default setting to null appears to have no impact.

The solution is to change the origin path default to "". This should be backwards compatible with exisiting deployments

jmgreg31 commented 3 years ago

Solved with https://github.com/jmgreg31/terraform-aws-cloudfront/pull/38