search

jmhertlein / MCTowns

A versatile and powerful town plugin using WorldGuard and the Bukkit API for Minecraft.
http://dev.bukkit.org/server-mods/mctowns/
GNU General Public License v3.0
8 stars 3 forks source link

Plot renting and improved WG flag support #82

Open tylerking opened 9 years ago

tylerking commented 9 years ago

So for the placeholders it would be great to have:

Town Name Mayor Assistant Resident Amount Bank Balance Territory Amount Plot Amount MOTD

Also, I'd love to be able to set up a hotel and rent out the rooms. I know this doable in Residence but the commands are way too difficult for some people to wrap their heads around and I just like MCTowns better. So that being said have you considered adding in an additional subplots that can be added into plots and a renting solution?

One more question. What about adding better control of the WorldGuard flags. So for instance being able to set the default flags in the config and then an option to allow or disallow the mayor to change certain flags?

hockeymikey commented 9 years ago

Take that up with extendedclip. The place holders aren't bundled with MCTowns, he just grabs the data from it.

That's a great idea, had a similar one earlier. Basically the ability to add other players to plots who are not members of the town. They can build and everything on that plot but they are not apart of the town. That way friends in other towns can build together or plots in a town can be sold.

Agreed, we need control over WorldGuard flags. No reason why mayors should have the ability to add a gamemode creative flag.

tylerking commented 9 years ago

Directly from Everdras

"I've actually been working on the issue of adding chat prefixes. It's very difficult to do in a single way that works with multiple chat plugins (I'd been trying to use Vault for it). If you would like me to add support for DeluxeChat specifically, I can definitely make that happen.

Could you open an issue on GitHub and give me a little more information on how exactly you would like the feature to work? What kinds of options you want in it, etc."

jmhertlein commented 9 years ago

it can go either way- he could pull the data out of my plugin, or I can add placeholders.

(Sorry for not getting back to you on this sooner- busy week)

So, as far as DeluxeChat goes, I will not be adding support for it to MCTowns. DeluxeChat is non-free software, and I feel it would ethically incorrect to make functionality of a Free Software program like MCTowns depend on non-free code in any capacity.

From DeluxeChat's page: 

You will not redistribute the DeluxeChat plugin or any of its source code to anyone publicly or privately.

You will not attempt to modify the DeluxeChat plugin source code without direct permission from me.

(For a similar ethical situation, look at the lashback Firefox has gotten for integrating Pocket support)

Renting and better flag control, however, sounds good. I'll add them to my to-do list.

tylerking commented 9 years ago

Ok. Mostly free plugins add placeholders that work in DeluxeChat and the author encourages plugin developers to make placeholders by sharing the hook example to do so.

"Here is the API package if you don't have DeluxeChat but want to add placeholders for people who use your plugin:" https://github.com/extendedclip/DeluxeChatPlaceholderAPI/tree/master/src/me/clip/deluxechat/placeholders

You obviously are under no obligation to add the placeholders but I'm just confused because, well this was said: "If you would like me to add support for DeluxeChat specifically, I can definitely make that happen."

Furthermore, the PlaceholderAPI that DeluxeChat uses is actually free so its not unethical at all to create some placeholders for your plugin: https://www.spigotmc.org/resources/placeholderapi.6245/

jmhertlein commented 9 years ago

The problem is that, by adding support for a non-free plugin, I'm encouraging users to use non-free software.

And yes, I know it's legal for me to create the placeholders, and I know that the developer offers an API to do so. Though, the API's code doesn't have a license associated with it, which actually makes it a grey area in the US since all works default to "all rights reserved"- though GitHub gives you an "implied" license to fork the code.

But that's beside the point. The main issue is that the author specifically disallows two of the four essential software freedoms in his license of DeluxeChat (the freedom to share the source code, and the freedom to modify the program to make it do what you want).

I don't want to encourage users to use software that's harmful to their freedoms as a user.

Further reading:

tylerking commented 9 years ago

Alright. Fair enough. I can't really push it after reading the facts. Thanks for sharing those btw. I'll reach out to extended_clip and see what I can do about him making some placeholders on his side. I'll be looking forward to the renting and flags regardless. Cheers

hockeymikey commented 9 years ago

Hey just curious if there is any progress on the plot renting? I have players that want to make a hotel but can't due to the limitations at the moment.

thanks

jmhertlein commented 9 years ago

No progress on this yet. I'll see if I have time this weekend. Currently juggling full time employment, a fiancee and a different side project.