search

jmhobbs / cultofthepartyparrot.com

PARTY OR DIE
http://cultofthepartyparrot.com
Other
1.47k stars 308 forks source link

Parrot Overload #340

Open jmhobbs opened 5 years ago

jmhobbs commented 5 years ago

There are.... so many parrots. The website is dragging on mobile, and spinning fans on desktop.

We need to split things up and load them in chunks, or do multiple pages or something.

Any input is appreciated!

uberchemist commented 5 years ago

I take full responsibility 😭😭😭

Flag Parrots probably need their own page...

jmhobbs commented 5 years ago

It’s a glorious problem to have!!!

francoislg commented 5 years ago

Wouldn't a simple solution work for now, and see whether this needs to be improved later?

I think putting the Flag Parrot behind a lazy collapsible section would be fine and quite easy :)

jmhobbs commented 5 years ago

I'm sticking them on their own page for now, happy to accept PR's that improve it.

Screen Shot 2019-03-15 at 7 06 07 PM
uberchemist commented 5 years ago

Looks good to me! Would the 6 parrots around the button load randomly? That would be cool!

jmhobbs commented 5 years ago

That would be cool! I'll see how much trouble that would be to do.

jmhobbs commented 5 years ago

Done! I'll leave this open for other ideas if anyone has them.

uberchemist commented 5 years ago

Random parrot flags! I love it! ❤️

uberchemist commented 5 years ago

Also, for the flags page, there's some inconsistency in the naming. For example, some are named in the format of "[Country Adjective] Parrot" while others use "[Country Name] Parrot" and the rest just use "[Country Name]". We should choose one format and make it uniform. Also, I'd recommend renaming the informal "America Parrot" to the more universal "United States Parrot".

jmhobbs commented 5 years ago

Fixed those up in #351 @uberchemist