search

jmhobbs / cultofthepartyparrot.com

PARTY OR DIE
http://cultofthepartyparrot.com
Other
1.48k stars 311 forks source link

Added Resonating Red Parrot for Hacktoberfest! #643

Closed WeiJian123-tech closed 1 year ago

WeiJian123-tech commented 1 year ago

Here is my parrot GIF that I created with Photpea for Hacktoberfest. I couldn't find any static jpgs or pngs for blue and green parrot so I went with red parrot which was readily available from https://cultofthepartyparrot.com as the first frame.

jmhobbs commented 1 year ago

I dig it! But the full re-formatting of the YAML file is a bit much, can you make it so that only has your addition as the change? Thanks!

WeiJian123-tech commented 1 year ago

I redownloaded the parrots.yaml file from your main GitHub branch and reentered Resonating Red Parrot's .yaml information without reformatting the entire parrots.yaml file. Sorry about that. I thought I had to deploy as a step before contributing so I npm installed cultofthepartyparrot. It might have been me running npm that changed parrots.yaml file's format but I am not entirely sure.

image

Is this a good fix even though my check now fail?

jmhobbs commented 1 year ago

Hey @WeiJian123-tech, no worries, I'm not sure what went wrong there. I hope you don't mind, I cleaned up the conflicts so that this would deploy and we could merge it.

Thanks for adding this parrot!

WeiJian123-tech commented 1 year ago

That is quite alright. I really don't mind. It was fun creating and contributing a cultoftheparrot.com parrot .gif. 😄