search

jmhobbs / kohana-3-migrations

A simple, SQL based migrations system for Kohana 3.
19 stars 6 forks source link

change Kohana::config to Kohana::$config->load for Kohana >= 3.2 #2

Closed iGore closed 12 years ago

jmhobbs commented 12 years ago

Looks good, thanks @iGore!

One question before I merge though, why the tilde on the end of classes/controller/migrations.php~ ?

Is that a new 3.2 convention for something? Does it have meaning?

If so, should we remove the non-tilde version?

Thanks!

jmhobbs commented 12 years ago

I merged a a couple commits into a 3.2 branch, including one of yours.

Your most recent one clobbered too many lines, so I didn't include it.

I opened issue #3 for 3.2 compatibility, please take a look at the 3.2 branch and work against that.

Thanks!

iGore commented 12 years ago

Sorry, the file with the "~" was a autosave file. I take my commits to prematurely.

I take a look at the migrations class from fuel framework (http://fuelphp.com/docs/general/migrations.html) and the Kohana Migrations for Kohana 2.2 (https://code.google.com/p/kohana-migrations/), it is class based. Do you think about a Class based migration?

Update

I saw one of your other project was a Kohana class based migration.

I start my work with your migrations today and it works fine. Nice work, thanks!

Sorry for my low level english.

jmhobbs commented 12 years ago

No problem, we all commit too soon sometimes :-)

For anyone who stumbles along this thread later, the referenced project is here: https://github.com/jmhobbs/K3-Migrate