jmhodges / bazel_gomock

Code to create Go mocks for bazel targets using mockgen
MIT License
58 stars 30 forks source link

Remove GoPath dependency from gomock reflection #12

Closed amckinney closed 5 years ago

amckinney commented 5 years ago

The current gomock.bzl implementation declares a dependency on the GoPath provider to virtualize a GOPATH in the execution of mockgen.

Upon further investigation and experimentation, it appears that this isn't necessary for reflect-based mock generation. This opts to remove the GoPath dependency from the reflect path.

jmhodges commented 5 years ago

This is great. Thanks!