remove gopath dependency completely

jmhodges / bazel_gomock

Code to create Go mocks for bazel targets using mockgen

MIT License

59 stars 29 forks source link

remove gopath dependency completely #16

Closed jmhodges closed 5 years ago

jmhodges commented 5 years ago

This removes the dependency on a rules_go-made GOPATH when generating a mock from a specific file with the source parameter.

jmhodges commented 5 years ago

Forgot to mention but this should speed up builds depending on gomock calls with the source parameter!

linzhp commented 5 years ago

This change causes gomock rule download Go modules at build time, making the build less hermetic. Can you help me understand why not relying on gopath?