Unbreak gomock() in combination with remote builds

jmhodges / bazel_gomock

Code to create Go mocks for bazel targets using mockgen

MIT License

59 stars 29 forks source link

Unbreak gomock() in combination with remote builds #3

Closed EdSchouten closed 5 years ago

EdSchouten commented 5 years ago

The attached changes make gomock() work when used in projects that are built against a remote buildfarm. Some of the input file dependencies were missing in that case.

jmhodges commented 5 years ago

This is wonderful! I love the formatting changes but they made it hard to see what the changes are. Would you mine separating out the formatting from the functional changes?

EdSchouten commented 5 years ago

It's already split up in two commits, right?

https://github.com/jmhodges/bazel_gomock/pull/3/commits/2db7507441677b120bb6fc27666089025672c6e7 https://github.com/jmhodges/bazel_gomock/pull/3/commits/7bd9a6fd573a95610a832c50512f18a3b736693e

jmhodges commented 5 years ago

Well, this project merges PRs with squash to keep the history clean and linear.

jmhodges commented 5 years ago

Okay, I just split them up and merged the reformat. Thank you!