search

jmhodges / bazel_gomock

Code to create Go mocks for bazel targets using mockgen
MIT License
58 stars 30 forks source link

v1.1 issues with older bazel - comma after kwarg #40

Closed glukasiknuro closed 4 years ago

glukasiknuro commented 4 years ago

Reported error below. Downgrading to v1.0 fixes the issue:

bazel_gomock/gomock.bzl:136:21: unexpected tokens after kwarg bazel_gomock/gomock.bzl:136:21: syntax error at ',': expected bazel_gomock/gomock.bzl:145:9: Trailing comma is allowed only in parenthesized tuples.

Bazel did not allow trailing commas in argument lists after *args and **kwargs. It was fixed at Jul 2019: https://github.com/bazelbuild/bazel/pull/8966

Looks like bazel_gomock added those trailing spaces in this PR: https://github.com/jmhodges/bazel_gomock/pull/36/files#diff-f2a2e2908fa7f70ad46075c8f3b0329aR137

glukasiknuro commented 4 years ago

Created https://github.com/jmhodges/bazel_gomock/pull/41 and verified that it solves the issue @jmhodges

glukasiknuro commented 4 years ago

Was fixed in v1.2