Remove interfaces attribute from source mode

jmhodges / bazel_gomock

Code to create Go mocks for bazel targets using mockgen

MIT License

58 stars 30 forks source link

Remove interfaces attribute from source mode #42

Closed linzhp closed 4 years ago

linzhp commented 4 years ago

When mockgen is running in source mode, it always generate mocks for all interfaces in the source file, regardless of interfaces are provided in the argument. In fact, it doesn't need that argument. Bazel gomock rule should not require interfaces attribute either.

jmhodges commented 4 years ago

Thanks!

jmhodges commented 3 years ago

In retrospect, I should have noticed this was an API break and said no (but accepted the README changes). It even broke some old code of my own! Probably been too long now, but lesson learned from me.