search

jmikola / JmikolaAutoLoginBundle

Authenticate users in your Symfony app via a single query parameter (e.g. email and newsletter links).
MIT License
84 stars 16 forks source link

Compatibility for Symfony 3.0 #17

Closed bertoost closed 8 years ago

bertoost commented 8 years ago

It now breaks at all for the security bundle, but probably need some more enhancements for Symfony 3.0. Would be nice to have this back in 3.0 too.

jmikola commented 8 years ago

@bertoost: Please take a look at the referenced PRs and let me know if that works for you. I was able to verify library and bundle compatibility with a new Symfony 3.0 project by merely relaxing the LoggerInterface type hint in https://github.com/jmikola/AutoLogin/issues/18 (everything else is documentation and composer.json updates).

bertoost commented 8 years ago

@jmikola Thanks! Will try this soon. I will let you know.

bertoost commented 8 years ago

@jmikola How can I do this? I'm sure I need to do something else then composer require jmikola/auto-login-bundle But not sure what to change

Sander-Toonen commented 8 years ago

You can add the following to you composer.json to checkout the symfony3-compat banch:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/jmikola/AutoLogin.git"
        }
    ],
    "require": {
        "jmikola/auto-login-bundle": "dev-symfony3-compat"
    }
}

Then, just run composer update jmikola/auto-login-bundle

bertoost commented 8 years ago

Unfortunate I can't install the dev-symfony3-compat version.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for jmikola/auto-login-bundle dev-symfony3-compat -> satisfiable by jmikola/auto-login-bundle[dev-symfony3-compat].
    - Conclusion: remove symfony/symfony v3.0.4
    - Conclusion: don't install symfony/symfony v3.0.4
    - jmikola/auto-login-bundle dev-symfony3-compat requires jmikola/auto-login ^1.2.2 -> satisfiable by jmikola/auto-login[v1.2.2].
    - jmikola/auto-login v1.2.2 requires symfony/http-kernel ~2.1 -> satisfiable by symfony/http-kernel[v2.1.0, v2.1.1, v2.1.10, v2.1.11, v2.1.12, v2.1.13, v2.1.
2, v2.1.3, v2.1.4, v2.1.5, v2.1.6, v2.1.7, v2.1.8, v2.1.9, v2.2.0, v2.2.1, v2.2.10, v2.2.11, v2.2.2, v2.2.3, v2.2.4, v2.2.5, v2.2.6, v2.2.7, v2.2.8, v2.2.9, v2.3
.0, v2.3.1, v2.3.10, v2.3.11, v2.3.12, v2.3.13, v2.3.14, v2.3.15, v2.3.16, v2.3.17, v2.3.18, v2.3.19, v2.3.2, v2.3.20, v2.3.21, v2.3.22, v2.3.23, v2.3.24, v2.3.2
5, v2.3.26, v2.3.27, v2.3.28, v2.3.29, v2.3.3, v2.3.30, v2.3.31, v2.3.32, v2.3.33, v2.3.34, v2.3.35, v2.3.36, v2.3.37, v2.3.38, v2.3.39, v2.3.4, v2.3.5, v2.3.6,
v2.3.7, v2.3.8, v2.3.9, v2.4.0, v2.4.1, v2.4.10, v2.4.2, v2.4.3, v2.4.4, v2.4.5, v2.4.6, v2.4.7, v2.4.8, v2.4.9, v2.5.0, v2.5.1, v2.5.10, v2.5.11, v2.5.12, v2.5.
2, v2.5.3, v2.5.4, v2.5.5, v2.5.6, v2.5.7, v2.5.8, v2.5.9, v2.6.0, v2.6.1, v2.6.10, v2.6.11, v2.6.12, v2.6.13, v2.6.2, v2.6.3, v2.6.4, v2.6.5, v2.6.6, v2.6.7, v2
.6.8, v2.6.9, v2.7.0, v2.7.1, v2.7.10, v2.7.11, v2.7.2, v2.7.3, v2.7.4, v2.7.5, v2.7.6, v2.7.7, v2.7.8, v2.7.9, v2.8.0, v2.8.1, v2.8.2, v2.8.3, v2.8.4].
    - jmikola/auto-login v1.2.2 requires symfony/http-kernel ~2.1 -> satisfiable by symfony/http-kernel[v2.1.0, v2.1.1, v2.1.10, v2.1.11, v2.1.12, v2.1.13, v2.1.
2, v2.1.3, v2.1.4, v2.1.5, v2.1.6, v2.1.7, v2.1.8, v2.1.9, v2.2.0, v2.2.1, v2.2.10, v2.2.11, v2.2.2, v2.2.3, v2.2.4, v2.2.5, v2.2.6, v2.2.7, v2.2.8, v2.2.9, v2.3
.0, v2.3.1, v2.3.10, v2.3.11, v2.3.12, v2.3.13, v2.3.14, v2.3.15, v2.3.16, v2.3.17, v2.3.18, v2.3.19, v2.3.2, v2.3.20, v2.3.21, v2.3.22, v2.3.23, v2.3.24, v2.3.2
5, v2.3.26, v2.3.27, v2.3.28, v2.3.29, v2.3.3, v2.3.30, v2.3.31, v2.3.32, v2.3.33, v2.3.34, v2.3.35, v2.3.36, v2.3.37, v2.3.38, v2.3.39, v2.3.4, v2.3.5, v2.3.6,
v2.3.7, v2.3.8, v2.3.9, v2.4.0, v2.4.1, v2.4.10, v2.4.2, v2.4.3, v2.4.4, v2.4.5, v2.4.6, v2.4.7, v2.4.8, v2.4.9, v2.5.0, v2.5.1, v2.5.10, v2.5.11, v2.5.12, v2.5.
2, v2.5.3, v2.5.4, v2.5.5, v2.5.6, v2.5.7, v2.5.8, v2.5.9, v2.6.0, v2.6.1, v2.6.10, v2.6.11, v2.6.12, v2.6.13, v2.6.2, v2.6.3, v2.6.4, v2.6.5, v2.6.6, v2.6.7, v2
.6.8, v2.6.9, v2.7.0, v2.7.1, v2.7.10, v2.7.11, v2.7.2, v2.7.3, v2.7.4, v2.7.5, v2.7.6, v2.7.7, v2.7.8, v2.7.9, v2.8.0, v2.8.1, v2.8.2, v2.8.3, v2.8.4].
    - don't install symfony/http-kernel v2.3.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.11|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.12|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.13|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.14|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.15|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.16|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.17|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.18|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.19|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.20|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.21|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.22|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.23|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.24|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.25|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.26|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.27|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.28|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.29|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.30|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.31|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.32|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.33|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.34|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.35|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.36|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.37|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.38|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.39|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.3.9|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.4.9|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.11|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.12|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.5.9|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.11|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.12|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.13|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.6.9|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.11|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.7.9|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.8.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.8.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.8.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.8.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.8.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.11|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.12|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.13|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.1.9|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.0|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.1|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.10|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.11|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.2|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.3|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.4|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.5|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.6|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.7|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.8|don't install symfony/symfony v3.0.4
    - don't install symfony/http-kernel v2.2.9|don't install symfony/symfony v3.0.4
    - Installation request for symfony/symfony == 3.0.4.0 -> satisfiable by symfony/symfony[v3.0.4].
Sander-Toonen commented 8 years ago

@bertoost : I just gave it a try myself. The problem was the dependency on jmikola/auto-login which depend on version 2 of some Symfony components. We therefore need to use the symfony3-compat branch for that library as well, and then fake its version to satisfy composer. The following worked for me:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/jmikola/AutoLogin.git"
        },
        {
            "type": "git",
            "url": "https://github.com/jmikola/JmikolaAutoLoginBundle.git"
        }
    ],
    "require": {
        "jmikola/auto-login": "dev-symfony3-compat as 1.2.x-dev",
        "jmikola/auto-login-bundle": "dev-symfony3-compat"
    }
}

@jmikola : I couldn't find any problems. Looks good to go.

Sander-Toonen commented 8 years ago

@jmikola I have tested the symfony3-compat branch in Symfony 3.0 and did not encounter any issues. I even have it running in production for a week now so I would say it is good to go.

jmikola commented 8 years ago

Released: