search

jmikola / JmikolaAutoLoginBundle

Authenticate users in your Symfony app via a single query parameter (e.g. email and newsletter links).
MIT License
84 stars 16 forks source link

Added support for Symfony 4.0 where DefinitionDecorator class is removed #24

Closed SvetlinStaev closed 6 years ago

SvetlinStaev commented 6 years ago

To finalize the Symfony 4.0 support for the bundle a conditional check for the DefinitionDecorator must be done as it is not available in 4.0+

jmikola commented 6 years ago

Before merging and tagging a new version of the bundle, are there any additional changes required for the base AutoLogin package, or is 1.2.4 sufficient? The previously PRs merged for Symfony 4.0 compatibility only updated the Composer dependencies to add || ^4.0, so it's understandable that they might have missed something (as you've caught in this PR).

SvetlinStaev commented 6 years ago

The bundle works fine in Symfony 4.0.6 with the exception of the change in this PR which errors out as it doesn't find the class removed in 4.0+.

jmikola commented 6 years ago

Tagged v1.1.4 with this change. Thanks!