search

jming422 / fira-code-mode

Emacs minor mode for Fira Code ligatures using prettify-symbols
GNU General Public License v3.0
103 stars 11 forks source link

Add fira-code-mode-install-fonts command for Linux and mac OS #10

Closed rhdxmr closed 4 years ago

rhdxmr commented 4 years ago

This PR adds M-x fira-code-mode-install-fonts command which automatically installs required fonts. The font file is attached to #9 of this repository and gzip compressed. The command downloads it, decompress it and runs fc-cache command.

rhdxmr commented 4 years ago

Hello @jming422 Can you review this PR?

jming422 commented 4 years ago

Hello @jming422 Can you review this PR?

Gladly, thanks for the contribution! I won't have time to look it over until tomorrow, but I'll certainly look this over; this would be a great feature. Reminds me of how all-the-icons does it, which I like.

rhdxmr commented 4 years ago

@jming422 OK. I will modify the code to apply your feedback including adding description about this function. Before that, FiraCode Regular Symbol.otf file should be pushed to this repository. Let me know when the file is pushed, then I will do force-push new code. Thanks,

jming422 commented 4 years ago

@rhdxmr Okay, the otf file is now checked into the repo! It should be accessible at https://raw.githubusercontent.com/jming422/fira-code-mode/master/fonts/FiraCode-Regular-Symbol.otf

rhdxmr commented 4 years ago

@jming422 I pushed new code. README is modified and gunzip is removed.

rhdxmr commented 4 years ago

@jming422 I just pushed new code. I appreciate your feedback on this PR. Thanks,