jming422 / fira-code-mode

Emacs minor mode for Fira Code ligatures using prettify-symbols
GNU General Public License v3.0
103 stars 11 forks source link

Installations problems on autoload #20

Closed brenoos closed 3 years ago

brenoos commented 3 years ago

Hello. I'm trying to install the package via MELPA but I'm getting this error

emacs error

I already tried to reinstall and the problem persist.

I'm using doom emacs emacs 27.2

jming422 commented 3 years ago

What installation command(s) did you run? Doom requires installing packages in its own special way, so the instructions in this package's README won't quite work.

Also, Doom Emacs comes with its own ligatures module which is very robust and provides more features than my package: https://github.com/hlissner/doom-emacs/blob/develop/modules/ui/ligatures/README.org

brenoos commented 3 years ago

Hello @jming422

I only tried the instructions on the "Getting Started" section on the README

jming422 commented 3 years ago

That makes sense then - the README currently only has instructions for vanilla Emacs, and those instructions won't work for Doom Emacs.

I'd recommend that you either:

If you find a way that works, I would happily accept a pull request that adds Doom installation instructions to my README!

brenoos commented 3 years ago

I'm having problems with ligatures on doom Emacs too.

Thanks for your help will try to solve this first