Closed mkrupcale closed 7 years ago
I had a quick look and it looks fine for me. Thank you a lot for this work and for the contribution to this repository.
For your information: I will try to publish the plugin (your updated version) on a p2 update site on Bintray.
Glad I could make improvements to this plugin. That sounds like a good idea publishing it there.
Have a look at the new project page: https://jmini.github.io/Eclipse-Copyright-Generator/ You will find the link to the P2 Update Site.
Awesome it looks good. Having the P2 Update Site is especially useful I think because it will lower the barrier for newcomers to use this plugin. I had actually never worked with Eclipse plugins before and so I had to compile and install it manually.
bin/
filesfirstInstructionFinded
to more grammatically correctfirstInstructionFound
getCdataTextContent()
method to concatenate text content of CDATA_SECTION child nodes for given parent node. This allows for possibility of: 1) child text (i.e. whitespace) nodes for nicer XML formatting; 2) although unlikely, CDATA sections cannot contain]]>
, so one must use multiple consecutive CDATA sections, splitting this triad, as in<![CDATA[]]]]><![CDATA[>]]>
.getCdataTextContent()
method inloadHeadersFormats()
when parsing header XML file and inreadCopyrights()
when parsing copyrights XML fileHeaderFormat
with default C/C++-style comment formatslicense.txt
toCOPYING
to be more consistent with GNU convention