jmiskovic / hexpress

Modern mobile music instrument
The Unlicense
95 stars 4 forks source link

instant crash on Android 13 (S23U) #12

Open Linecutterx opened 1 year ago

Linecutterx commented 1 year ago

V39 crashes on launch. "There is a bug", according to android. Clearing cache & data does not help, nor does uninstalling & installing from the releases on github.

technopagan commented 1 year ago

2nd'ing this issue. Android 13 (AOSP, LOS20) instant crash, installed via FDroid (Izzy's repo).

jmiskovic commented 1 year ago

Thanks for reporting this.

Can you please try to disable the Bluetooth and try starting the app?

My current assumption is that one of Love2D dependency libraries checks if Bluetooth is active and then attempts to fetch the list of nearby devices. Currently (v0.39) the app doesn't require Bluetooth permissions, so this fails with a crash. I tried adding the permission as a quick fix, but Google rejected the 0.40 app update.

Linecutterx commented 1 year ago

Turning off Bluetooth does fix the crash, so your assumption seems correct. Not an ideal way to use the app, but hopefully that gives you a way forward. Could you create a release with the Bluetooth permission fix, for github & f-droid while you work out the Google acceptable fix (& report the lack of error checking to the library's author)?

jmiskovic commented 1 year ago

I've made the release to work around this issue. It should also picked up by Izzy's repo automatically on their schedule.

For context, the v39 was made because they delisted the app from the Google Play Store (too old SDK). This Bluetooth crashing issue in v39 was due to one of pointless permission changes between SDK versions. While they happily published the v39 update, they are now rejecting the hotfix v40 that would fix it for most users. So, the Google Play Store users are stuck with this bug for the moment :(

For the better more robust bluetooth permission handling I will need to rebase to the most recent love-android version. At the moment I'm reluctant to do so because I noticed it introduced a bug (black screen when switching away and back to love2d app).

Linecutterx commented 1 year ago

Can confirm that granting permission for Nearby devices fixes the instant crash. Installing as an update does not prompt for the new permission to be granted, so f-droid users are likely to be caught out if they just accept the update.

mayhair commented 11 months ago

It still crashes on my Android 14 phone, even if I enable the "Nearby devices" permission via settings.

Dewm-Bot commented 9 months ago

I can also confirm that on Android 14 it crashes on startup. Is there any way I could generate or find an error log for you?

I am on a Samsung A52s running One UI 6.0 and Android 14. I have tried both with Bluetooth and location off and on to no avail.

jmiskovic commented 4 months ago

I believe this issue has been solved in v41, please report if you have any issues with it.

The Google Play and F-Droid will be updated as well in a week or two.

Dewm-Bot commented 3 months ago

I can confirm this issue has been resolved in the latest update!

Thank you, I really appreciate it.