jmix-framework / jmix-ui-samples-2

Jmix UI Samples. Online at https://demo.jmix.io/ui-samples/
https://www.jmix.io
Apache License 2.0
2 stars 0 forks source link

Custom reusable component #3

Closed honest-niceman closed 1 year ago

honest-niceman commented 1 year ago

Fixed, @KremnevDmitry please take a look

knstvk commented 1 year ago

I would suggest the following changes.

  1. Instead of placing components from top to bottom, add a TabSheet to the sample view with 2 tabs: "Declaratively added component" and "Programmatically added component".
  2. Improve the description:
    • Explain what custom component is for: to reuse UI parts in different views, etc.
    • Explain what custom component can do: contain other components, load data, connect to data containers of the host view, etc.
    • Explain the example: "In this example, we explain how to create and use a custom component for editing addresses. The component consists of ... edit fields, it loads lists of countries and cities, it saves values to ..."
    • Then explain each file as it's done now.

Consult with GG and DK.

honest-niceman commented 1 year ago

Fixed. @knstvk please take a look

honest-niceman commented 1 year ago

Name for the component has been adjusted