search

jmix-framework / jmix

Jmix framework
https://www.jmix.io
Apache License 2.0
709 stars 123 forks source link

GenericFilter condition with URL query parameters facet is added endlessly #3490

Closed KremnevDmitry closed 1 month ago

KremnevDmitry commented 3 months ago

Environment

Jmix version: 2.4.999-SNAPSHOT

Bug Description

Probably after: #3419 Adding generic filter conditions loops.

Steps To Reproduce

Steps to reproduce the behavior.

  1. Create a snapshot project
  2. Run the project
  3. Open the UserListView
  4. Add any condition

Current Behavior

The condition is added endlessly.

Expected Behavior

The condition is added only ones.

glebfox commented 2 months ago

See also Vaadin issue: https://github.com/vaadin/flow/issues/19580

KremnevDmitry commented 2 months ago

Reason for regression: using ReactRouting as the main routing in Vaadin since 24.4.

Temporary workaround: disable ReactRouting using build.gradle file

vaadin {
    reactEnable = false
}
glebfox commented 1 month ago

Fixed in: https://github.com/vaadin/flow/pull/19736 by providing a new API Wait for: https://github.com/jmix-framework/jmix/issues/3704 and pass false to com.vaadin.flow.component.page.History#replaceState(elemental.json.JsonValue, com.vaadin.flow.router.Location, boolean)

rusiaikinat commented 1 month ago

Jmix version: 2.4.999-SNAPSHOT Jmix Studio plugin version: 2.4.SNAPSHOT6826-242 IntelliJ version: IntelliJ IDEA 2024.2.2 (Ultimate Edition) Kotlin, Java