jmix-projects / jmix-ui

DEPRECATED. Use https://github.com/jmix-framework/jmix
https://www.jmix.io
3 stars 7 forks source link

TagField does not implement error style #674

Closed Flaurite closed 2 years ago

Flaurite commented 2 years ago

Description

Steps to reproduce

  1. Add tagField to a screen:
    <tagField id="tagField" required="true"/>
  2. Launch the app and open screen.

ER image

AR image

Breaking changes

TagField has changed the inner HTML layout. Now all its content (tags, field, clear-all button) is placed into one <div> with class jmix-tagfield-layout. Therefore some CSS selectors for TagField content may not work, for instance:

.jmix-tagfield > .jmix-taglabel {
  background-color: green;
}

If application has custom styles for TagField like above, they should be reworked considering div with jmix-tagfield-layout class.

QA

Additional cases:

  1. Make sure that error state is gone if TagField with required="true" has a value.
  2. Check that TagField with required="true" has asterisk in the same line in the Form and HBoxLayout or VBoxLayout.
  3. Check that TagField with required="true" is highlighted in Halo, Hover and Helium theme.
  4. Your cases.
owlet1997 commented 2 years ago

TC 1: used theme: helium

AR: asterisk is not in the same line: vbox/hbox: image

UPD: not a bug