search

jmix-projects / jmix-ui

DEPRECATED. Use https://github.com/jmix-framework/jmix
https://www.jmix.io
3 stars 7 forks source link

[UserSubstitutionsScreen] Improve commit logic #689

Closed glebfox closed 2 years ago

glebfox commented 2 years ago

Currently, the CreateAction doesn't commit UserSubstitutionEntity - newly created are commited by the OK button of the screen, all at once, but Edit and Remove action commit immediately. Also, cancel action doesn't check if there are new entities and cancel creation without warning.

konyashkina commented 2 years ago

Now it works as designed. But I think it would be userfriendly to add some notification before commit Remove action.

konyashkina commented 2 years ago

Tested on Jmix version: 1.1.0-SNAPSHOT Jmix Studio plugin version: 1.1.SNAPSHOT3625-212 IntelliJ version: IntelliJ IDEA 2021.2.2 (Ultimate Edition)