jml / undistract-me

Notifies you when long-running terminal commands complete
Other
540 stars 48 forks source link

Move the time taken to the notification summary #34

Closed nocnokneo closed 8 years ago

nocnokneo commented 8 years ago

This change has a couple benefits:


This change is Reviewable

jml commented 8 years ago
:lgtm:

Thanks!

Previously, nocnokneo wrote… > #### Move the time taken to the notification summary > > This change has a couple benefits: > - Notify messages with a long body can get cut truncated by the user's > > notification GUI. Some GUIs (such as GNOME) don't offer any way to see > > the truncated message at so the information about how long the command took > > is completely lost. > - The message body becomes just the command string which nullifies the need > > for quoting the command string string > >

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

jml commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable