jml / undistract-me

Notifies you when long-running terminal commands complete
Other
539 stars 48 forks source link

Add option to play notification sound. #41

Closed akaydesai closed 7 years ago

akaydesai commented 7 years ago

Default behavior is unchanged - does not play notification sound. To change this, set UDM_PLAY_SOUND in bashrc to non-zero value.

jml commented 7 years ago

Thanks! I'm unsure about this change. Could you please document these optional dependencies in the README?

akaydesai commented 7 years ago

I have explained the dependencies in the comments above, and also put in a paragraph in the README under the Configuration section. Alternatively we could remove the sound-theme-freedesktop dependency and provide the sound file in the source tree itself, or let the user select a file themselves. But since most desktop environments usually ship with the two packages installed, adding two tiny dependencies doesn't seem to be a big deal.

akaydesai commented 7 years ago

Covered all the grammar bases. :)

akaydesai commented 7 years ago

Accidentally closed this prematurely.

jml commented 7 years ago

Thanks!