jml / undistract-me

Notifies you when long-running terminal commands complete
Other
540 stars 48 forks source link

Incompatibility with any other script using `bash-preexec` #67

Open qbouvet opened 4 years ago

qbouvet commented 4 years ago

undistract-me is incompatible with any other script that relies on bash-preexec, for instance bash-timer.

That is because undistract-me uses variables precmd and preexec to pass its callback functions to bash-preexec. If any other script does the same thing, then whichever is sourced last overwrites these variables and the callbacks of the other scripts are discarded.

This is solved updating bash-preexec, I will send a PR shortly. Could you consider merging it in ? This is really useful for people using the script.

Best

qbouvet commented 4 years ago

See Pull Request #68