search

jmliu206 / LIC_TCM

MIT License
144 stars 22 forks source link

Some questions about the calculations of bpp #11

Open galijipaifan opened 1 year ago

galijipaifan commented 1 year ago

Hi,l have some questions about the calculations of bpp. In your code, you don't use the z_strings to calculate the bpp and you just use the y_strings to calculate it. l think that it is important to consider the z_string.

jmliu206 commented 1 year ago

We referred to compressai for the bpp calculation method. I think this code, in len(s[0]) for s in out_enc["strings"], computes for y_strings and z_strings since out_enc["strings"] includes both y_strings and z_strings. Can you check it again?

galijipaifan commented 1 year ago

Thank you very much, l was too careless.