jmmastey / chicagoapprenticeships

A site to list software apprenticeships in Chicago with details on what they provide (e.g. bennies?)
1 stars 2 forks source link

convert apprenticeship tiles away from <a> elements #1

Open jmmastey opened 7 years ago

jmmastey commented 7 years ago

It's nice that they're large click targets right now, but at the same time that has been a huge limiting factor for putting further links into the apprentice data. Here's what I think:

  1. Convert the <a> elements to <div> elements. I haven't tried this yet, but I think I recall the code for the masonry library or the CSS being dependent on the element type, so this may either be trivial, or a shit-show.
  2. Add some new target for clicking. Either we could make the logos clickable, or we could add a button at the bottom of the cards. My concern with the latter is that the cards are already so tall.
  3. Fix the existing data so that links can be handled gracefully. It may be necessary to run the JSON through a markdown parser, as I'd strongly prefer not to store HTML directly in apprenticeships.json.