search

jmmk / javascript-externs-generator

Generate externs for use with Google Closure Compiler
https://jmmk.github.io/javascript-externs-generator/
ISC License
135 stars 9 forks source link

Test interaction with iframe #18

Closed jmmk closed 6 years ago

jmmk commented 8 years ago

In #17, I found an issue where the iframe caused an identity comparison (===) to fail due to the iframe having a different scope than the default globals. The tests are only checking if the extern logic works properly, but not with the added complexity of the iframe sandbox.

Maybe we can run the tests in different "modes" to see if there are any differences, or simply use phantom and call extract-loaded from the tests instead of just extract.

jmmk commented 8 years ago

In #19 we saw that (instance? js/Node child) returns false because of the iframe