HEAD compile error?

[gliptak]

I'm seeing these errors (related to non-Unicode chars in the source?):

    [javac] Compiling 151 source files to c:\tmp\jmockit1\main\test-classes
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:115: error: unclosed character literal
    [javac]          mock.getDouble(); result = 54321; result = 'á';
    [javac]                                                     ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:115: error: illegal character: '\u00a1'
    [javac]          mock.getDouble(); result = 54321; result = 'á';
    [javac]                                                       ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:115: error: unclosed character literal
    [javac]          mock.getDouble(); result = 54321; result = 'á';
    [javac]                                                        ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:132: error: unclosed character literal
    [javac]       assertEquals('á', mock.getDouble(), 0);
    [javac]                    ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:132: error: illegal character: '\u00a1'
    [javac]       assertEquals('á', mock.getDouble(), 0);
    [javac]                      ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:132: error: unclosed character literal
    [javac]       assertEquals('á', mock.getDouble(), 0);
    [javac]                       ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:132: error: ';' expected
    [javac]       assertEquals('á', mock.getDouble(), 0);
    [javac]                              ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:132: error: ';' expected
    [javac]       assertEquals('á', mock.getDouble(), 0);
    [javac]                                          ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:173: error: unclosed character literal
    [javac]          mock.getByteWrapper(); result = 'ç';
    [javac]                                          ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:173: error: illegal character: '\u00a7'
    [javac]          mock.getByteWrapper(); result = 'ç';
    [javac]                                            ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:173: error: unclosed character literal
    [javac]          mock.getByteWrapper(); result = 'ç';
    [javac]                                             ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:185: error: unclosed character literal
    [javac]       assertEquals((byte) 'ç', mock.getByteWrapper().byteValue());
    [javac]                           ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:185: error: illegal character: '\u00a7'
    [javac]       assertEquals((byte) 'ç', mock.getByteWrapper().byteValue());
    [javac]                             ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:185: error: unclosed character literal
    [javac]       assertEquals((byte) 'ç', mock.getByteWrapper().byteValue());
    [javac]                              ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:185: error: ';' expected
    [javac]       assertEquals((byte) 'ç', mock.getByteWrapper().byteValue());
    [javac]                                     ^
    [javac] c:\tmp\jmockit1\main\test\mockit\ExpectationsUsingReturnTypeConversionTest.java:185: error: ';' expected
    [javac]       assertEquals((byte) 'ç', mock.getByteWrapper().byteValue());
    [javac]                                                                  ^
    [javac] 16 errors

Could you please comment? Thanks

[rliesenfeld]

Those characters are Unicode. Like just about any other open source codebase, UTF-8 is used for all source files.

[gliptak]

@rliesenfeld The problem I'm facing that I see compile errors against that source file, but somehow you seem to be able to compile ...

[rliesenfeld]

Maven compiles it just fine too. Are you sure you're not trying to compile using some character encoding other than UTF-8?

[gliptak]

yes, my codepage is 437 ...

C:\>chcp
Active code page: 437

I'm submitting a pull request to make Ant use UTF-8 too.

[rliesenfeld]

Hm, I never cared what the Windows codepage was, but I now see that the Ant "build" target was missing the "encoding" attribute.

The pom.xml files in the project all specify "UTF-8" as the "sourceEncoding", which is all that's needed for compilation through Maven. I rarely used Ant for building, using my Java IDE (IntelliJ) or Maven instead.