search

jmoenig / Snap

a visual programming language inspired by Scratch
http://snap.berkeley.edu
GNU Affero General Public License v3.0
1.49k stars 742 forks source link

Add `CopySelectionDialogMorph` #1648

Open tjvr opened 7 years ago

tjvr commented 7 years ago

Both #1646 and #1084 want a dialog for copying text out of Snap!. @cycomachead wants to standardise this :)

We should have a standard dialog for this; should this be part of Morphic perhaps?

cycomachead commented 7 years ago

I think it belongs with the rest of widgets.js which aren't quite morphic but are also mostly independent of Snap!.

tjvr commented 7 years ago

@cycomachead Do you want to do this? :)

tjvr commented 6 years ago

@brianharvey Please can you un-assign me from this? I think you or Jens mentioned somewhere they didn't like this. Thanks!

jmoenig commented 6 years ago

Hi @tjvr , I unassigned you from this just now. @cycomachead , do we still need that dialog now that we can just CMD-C out of Snap?

tjvr commented 6 years ago

Thanks Jens! :-)

Sent with GitHawk

cycomachead commented 6 years ago

Whether we need a widget is up for debate....

There seems to be little interesting pulling the save and share option, which is another reason why this would exist. That PR includes an non-factored out version of the dialog.

In any event, of course we still need a dialog with Cmd-C. That’s how this dialog works. It’s simply a destination for a text box that allows copy and paste. Also, it instructs users to use keyboard shortcuts because most users don’t know that they exist.

-- Michael Ball From my iPhone michaelball.co

On Oct 5, 2017, at 9:40 AM, Tim (blob8108) notifications@github.com wrote:

Thanks Jens! :-)

Sent with GitHawk

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.