search

jmoenig / Snap

a visual programming language inspired by Scratch
http://snap.berkeley.edu
GNU Affero General Public License v3.0
1.51k stars 745 forks source link

Built-in Costume Sizing Issues #1682

Open maryfries opened 7 years ago

maryfries commented 7 years ago

Some of the costumes are appearing at a larger size than ever before...

costume-sizing

jguille2 commented 7 years ago

Hi Mary,

Maybe you applied a resizing action before? resizingblocks You can check size reporter to see current value. sizereporter

Joan

maryfries commented 7 years ago

That is not the problem. Please try the "kai a" costume. It's now, suddenly, too big to match the other costumes.

jmoenig commented 7 years ago

Yes, this is definitely a real issue. These costumes clearly have been altered somehow at some time. @brianharvey , any idea?

jguille2 commented 7 years ago

Hi @maryfries , I see now. I tested your issue... but I loaded 'boy1 standing' costume (it's the same picture!!!) and this is ok.

Now I see 'kai a' costume with the problem reported.

Then, we have a problem with duplicates (not exactly duplicates, because they have different formats). And yes, there is a relation with #1681 and Jens's request to Brian (and the format info) and also with #1666 (a proposal for a new costume picker view... this could help in this theme).

Now we have some 'duplicates': "kai a"(png) and "boy1 standing"(gif), "dog2" (png and svg), "bat1" (png and svg), "girl3"(gif) and "hannah"(png)...

We need a bit of order.

Joan

brianharvey commented 7 years ago

@jmoenig I have no idea. All the costumes were uploaded at once in Dec; then a few of them (but not "kai a") in a batch Jan 15. The new costumes are all over the place on height; I wonder if Scratch is normalizing them when loading?

P.S. I could go through and normalize heights myself in Photoshop, but I'm afraid that doing so will make them much more pixellated. Do y'all think I should?