Block search input alignment doesn't seem right

[towerofnix]

When we're open in the "find blocks" palette, and the palette is at normal width, the magnifying glass icon overlaps the search field:

I think it would be better if it automatically stretched the search input so that there's a few pixels of margin between the magnifying glass button and the right edge of the search input.

Plus, that would solve this issue: at the moment, the search field doesn't resize based on your palette width, and I think it should.

[brianharvey]

Or when the search bar is shown, don't show the magnifying glass at all!

[towerofnix]

I think the idea is that the magnifying glass is an easy way to get in and out of the search bar. If the user clicks on the magnifying glass, they shouldn't have to use the escape key - which is on the keyboard, not the mouse - to get out of there. (To be fair, they could just select a different block category, but this doesn't seem like it would be obvious.)

[brianharvey]

Oh! It didn't even occur to me that clicking it again would get you out.

[jmoenig]

hmmm... that's what I did at first, not show the icon in the search pane at all. Then, on second thought, I added the button to users can click it to get back. But you're right, that might be overenginerring it.

[cycomachead]

Just curious -- why this button right here? I thought there was an objection to adding buttons like this? I think is good for visibility, though so I don't mind.

However, thinking about this location, a + for "Make a Block" would probably be more useful.

[jmoenig]

Yeah, I'm coming around ;-) The idea is to make some of the really cool Snap! features more discoverable, including search (what this is about), make a block (which I'm thinking about adding a block to each palette at the bottom of the primitives that will pre-select the category's color in the "make a block" dialog, and also a toggle in the top toolbar for "visible stepping".

[cycomachead]

Hahaha. Well there’s a closed PR that already has the code for the male a block button. :)

That seems fine by me too. Search being easily findable will be used by many, so I’m still glad to see this.

-- Michael Ball From my iPhone michaelball.co

On Sep 21, 2017, at 10:11 AM, Jens Mönig notifications@github.com wrote:

Yeah, I'm coming around ;-) The idea is to make some of the really cool Snap! features more discoverable, including search (what this is about), make a block (which I'm thinking about adding a block to each palette at the bottom of the primitives that will pre-select the category's color in the "make a block" dialog, and also a toggle in the top toolbar for "visible stepping".

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[brianharvey]

I like the idea of an always-visible make-a-block button. There's a huge chunk of unused real estate to the right of the sprite name, up top. The bottom of a palette isn't always visible. No need for a toggle for visible stepping! Since the left end of the slider already means something special (single step), the right end should too (no stepping). You could even make that more obvious by having the slider light up except when it's all the way to the right. And while we're chatting about buttons, I still hate it that after you push the undo button it turns into the redo button, and the undo button appears somewhere else. That's really counterintuitive. Make the redo button always visible, but greyed out if there's nothing to redo.

[towerofnix]

And while we're chatting about buttons, I still hate it that after you push the undo button it turns into the redo button, and the undo button appears somewhere else. That's really counterintuitive. Make the redo button always visible, but greyed out if there's nothing to redo.

+1!

(I'd add a :+1: to your post but you made multiple points, and it'd be ambiguous which one I'm particularly agreeing with.)

[cycomachead]

I agree with BH about the always visible-ness I’d make a block, though I do think it should be connected to the palette a bit more.

Not sure what’s best.

-- Michael Ball From my iPhone michaelball.co

On Sep 21, 2017, at 2:03 PM, Florrie notifications@github.com wrote:

And while we're chatting about buttons, I still hate it that after you push the undo button it turns into the redo button, and the undo button appears somewhere else. That's really counterintuitive. Make the redo button always visible, but greyed out if there's nothing to redo.

+1!

(I'd add a 👍 to your post but you made multiple points, and it'd be ambiguous which one I'm particularly agreeing with.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.