jmoenig / Snap

a visual programming language inspired by Scratch
http://snap.berkeley.edu
GNU Affero General Public License v3.0
1.5k stars 744 forks source link

URL containing tilde included in help text doesn't work when clicked #3323

Open brianharvey opened 7 months ago

brianharvey commented 7 months ago

For example, this help screen is in the streams library: map-help The second link, next to the last line, is https://people.eecs.berkeley.edu/~bh/61a-pages/Volume2/notes.pdf If you click it here, on the Github issue page, you'll get to my lecture notes. But if you click it in this project (find the MAP OVER STREAM block and get its help screen) it won't work.

I'm using Chrome on MacOS.

DarDoro commented 6 months ago

"~"

is ignored in regexp and breaks the URL parsing at

morphic.js

function isURLChar(aCharacter) {
    return aCharacter.match(/[A-z0-9./:?&_+%-]/);
}