search

jmoenig / morphic.js

a lively web GUI
GNU Affero General Public License v3.0
179 stars 49 forks source link

NS_ERROR_FAILURE on page load (height) #53

Open brollb opened 4 years ago

brollb commented 4 years ago

A collaborator of mine recently ran into the NS_ERROR_FAILURE error on Firefox when working on his mac. The line throwing the error was https://github.com/jmoenig/morphic.js/blob/master/morphic.js#L1661.

I suspect the workaround used for width on retina displays needs to be applied for the height as well.

jmoenig commented 4 years ago

that's interesting, Brian. I can't reproduce this on my Mac with the latest FF (75.0). In fact, in the new Morphic2 version I've taken out the workaround altogether because I wasn't able to trigger the problem anymore. Can you tell us more about your collaborator's setup? Thanks!

brollb commented 4 years ago

He said he's using Firefox v75.0 on Catalina. I will ping him and see if he can provide any additional information!

cbradyatinquire commented 4 years ago

(HI JENS! The 'problem child' is Corey Brady)

OS Is Catalina OSX 10.15.1

Here's my hardware info... Model Name: MacBook Pro Model Identifier: MacBookPro16,1 Processor Name: 8-Core Intel Core i9 Processor Speed: 2.4 GHz Number of Processors: 1 Total Number of Cores: 8 L2 Cache (per Core): 256 KB L3 Cache: 16 MB Hyper-Threading Technology: Enabled Memory: 64 GB Boot ROM Version: 1037.80.53.0.0 (iBridge: 17.16.13050.0.0,0) Serial Number (system): C02ZT3EZMD6R Hardware UUID: 1BBD7BC3-5464-5542-A784-1700D361751A Activation Lock Status: Disabled

Firefox is version 75.0 (64bit)

let me know if there's any other info you want.

jmoenig commented 4 years ago

Hi Cory, thanks for this information! Is this one of the shiny new 16-inch MBP's? Can you let me know the devicePixelRatio of your monitor? open a console in FF and type in devicePixelRatio and let me know what it is. On my machine it's 2, I'm interested whether it's fractional on yours, even though I'm trying to disregard the fractional part. Tnx

cbradyatinquire commented 4 years ago

Mine is 2 as well. -CB

Corey Brady Assistant Professor, Learning Sciences Co-Director, Computational Thinking and Learning Initiative (CTLI) Department of Teaching and Learning Peabody College Vanderbilt University corey.brady@vanderbilt.edu

From: Jens Mönig notifications@github.com Reply-To: "jmoenig/morphic.js" reply@reply.github.com Date: Thursday, April 23, 2020 at 5:47 AM To: "jmoenig/morphic.js" morphic.js@noreply.github.com Cc: "Brady, Corey Edison" corey.brady@vanderbilt.edu, Comment comment@noreply.github.com Subject: Re: [jmoenig/morphic.js] NS_ERROR_FAILURE on page load (height) (#53)

Hi Cory, thanks for this information! Is this one of the shiny new 16-inch MBP's? Can you let me know the devicePixelRatio of your monitor? open a console in FF and type in devicePixelRatio and let me know what it is. On my machine it's 2, I'm interested whether it's fractional on yours, even though I'm trying to disregard the fractional part. Tnx

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjmoenig%2Fmorphic.js%2Fissues%2F53%23issuecomment-618330030&data=02%7C01%7Ccorey.brady%40vanderbilt.edu%7C1f3e42fc86b74514897308d7e773c018%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637232356637669822&sdata=0Lb0nnia9uM3Krmt9MqE3VzNE7NoSAN4ubHGWRqCNow%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAF3YMCIQQ2XHJ4KR2YL2DLROAME3ANCNFSM4MMZN2WQ&data=02%7C01%7Ccorey.brady%40vanderbilt.edu%7C1f3e42fc86b74514897308d7e773c018%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637232356637679815&sdata=%2F62WjayXy3XN9o1MAaPyi3eNpuAkTvmxRnQ2oVoVIFU%3D&reserved=0.