Open geeeeeeeeek opened 1 year ago
Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project. We are sorting the opened issues and pull requests and would like to know if you still NEED this merged. Thank you for your contribution.
This would be insanely useful 🙏🏻
Would love for this to be merged. I have been using sqlx with these changes for some time as it is a feature I find really useful.
@dlsniper This issue is precisely what forced me to ditch sqlx many years ago. Now I ran into it again in another project... Hoping to see this merged soon 🤞🏻
I tried this change in my project, and there are definitely breaking changes. The code copies from stdlib convertAssign
, but it's not fully compatible with it. For example, without this change scanning an int64
value into string
field works fine, but with this change it fails. I'm looking at the code trying to figure out I could address this issue.
@dlsniper @ardan-bkennedy I created another followup PR: https://github.com/jmoiron/sqlx/pull/950. It addresses incompatibility issues, adds tests, and is much shorter. It would be great if you could take a look at it!
Based on https://github.com/jmoiron/sqlx/pull/847, but fixed an issue that optional pointer fields are not handled correctly.