search

jmoiron / sqlx

general purpose extensions to golang's database/sql
http://jmoiron.github.io/sqlx/
MIT License
16.3k stars 1.09k forks source link

Add missing Tx.NamedQueryContext #914

Closed michaelshobbs closed 7 months ago

michaelshobbs commented 9 months ago

In an effort to use a postgres INSERT ... RETURNING stmt in a transaction, I found that there was a (*sqlx.Tx).NamedQuery but not a (*sqlx.Tx).NamedQueryContext. This PR attempts to remedy that.

ringmaster217 commented 7 months ago

@dlsniper I find myself needing this exact same addition, and you seem to be the most active contributor on this project at the moment. What would it take to get some eyes on this and get it merged?

dlsniper commented 7 months ago

Hi, @ringmaster217.

This is a duplicate of at least a few other opened PRs, e.g., https://github.com/jmoiron/sqlx/pull/724 or https://github.com/jmoiron/sqlx/pull/565.

I'll close this for now with the mention that it also lacks a test, which we have #724, for example.

As for merging the others, as @ardan-bkennedy and I are ramping up the maintenance of the repository, we'll try to merge this as soon as we can. Thank you for your understanding.